Added an option to change player speed while playing an emote #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the future I'll reimplement the Bukkit plugin, also this should be in the server-side mod too. |
KosmX
reviewed
Jun 14, 2021
| if(this.config.getBoolean("slownessWhilePlaying.enabled")) { | ||
| if(data.emoteData != null) { | ||
| if(!data.emoteData.isInfinite) { | ||
| Bukkit.getScheduler().runTaskLater(this, () -> { |
There was a problem hiding this comment.
This scheduled task may cause issues, when a player starts an emote, then stops earlier, then starts another.
I'll reimplement it, but it's mostly fine for now.
|
Checks are green, merging |
|
I'll try to do a fix release tomorrow, after that I'll start reimplementing the whole server-side logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to change player speed while playing an emote. Making the speed slower prevents players from unrealistically running while using emotes, and it's a nice feature to have.
Also fixed this exception: https://paste.gg/p/anonymous/35f0eb907bfd477aadce8ee2370ad694