Simplify history cleanup using Instant. #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if it is worth adding desugaring just to use Instant in the only one place. |
|
I thought I would start with a relatively small change, since this is my first contribution to this app. |
Isira-Seneviratne
force-pushed
the
Instant_history
branch
from
3c0c5c2
to
4f86efa
Compare
# Conflicts: # app/src/main/kotlin/org/koitharu/kotatsu/core/util/ext/Date.kt # app/src/main/kotlin/org/koitharu/kotatsu/shelf/ui/ShelfMenuProvider.kt
|
I`m not sure we will merge it since I have some concerns about desugaring and how it will affect the build time and apk size |
|
The app size is increased by 170 KB, and there doesn't seem to be much impact on the build time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.timeto be used on API levels < 26.Instantand its related classes for the timestamp calculation.