Add initial Java annotations for Kotlin sugar proposal #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice1000
reviewed
May 11, 2018
|
|
||
| ## Feedback | ||
|
|
||
| Discussion of this proposal is held in [this issue](TODO). |
tkindy
reviewed
May 14, 2018
| A Java library can do one of two things to go farther with its support: | ||
|
|
||
| 1. Publish Kotlin extensions inside their library or as a sibling artifact. | ||
| 2. Rewrite their public API (or the entire library in Kotlin). |
There was a problem hiding this comment.
Only "or the entire library" should be enclosed in the parentheses.
There was a problem hiding this comment.
Not sure how this made it in. I thought I fixed it long ago... Thanks! Updated.
* Two extension annotations or one? * @extension(type=FUNCTION/PROPERTY) * Okay, except when you add the name into this annotation the declaration site becomes very verbose. * @extension + inferred from name * Name doesn’t always match intent to be a property * @ExtensionFunction or @ExtensionProperty * Two annotations * Bean prefix removal only applies to one * Extension on method or on first parameter (receiver) * Method * Parameter * Like C# * Can be used on parameters which aren’t the first * Name inside parameter or separate annotation * @ExtensionFunction(“name”) * @ExtensionFunction @name(“name”) * @name can be re-used for parameter names * Lets @name be used places it isn’t desired * Lets @name be used without @ExtensionFunction which we don’t like Outcome: * When the name is combined with the annotation it makes more sense to have two annotations so you don’t have to supply name. * Two default value annotations or one with null literal * @DefaultValue(“null”) * Ambiguous between “null” string or null reference * @defaultnull or @DefaultValue(“0”) * Explicit, no edge cases * Default for collections? * What about collection types we don’t know about? * Expressions in a default? * No time to discuss * @ParameterName * No time to discuss Outcome: * No changes. Need to revisit. 1. Rename @KtName to @ParameterName, scope only to parameters 2. Add name property to @ExtensionFunction and @ExtensionProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.