-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-public markers aren't handled correctly for functions with default parameters #58
Labels
Comments
Released 0.10.1. Should be available on MavenCentral soon |
ilya-g
added a commit
to JetBrains/kotlin
that referenced
this issue
Nov 14, 2022
There were two problems in BCV fixed: - Kotlin/binary-compatibility-validator#36 - Kotlin/binary-compatibility-validator#58 Therefore some methods with default values and properties that mistakenly wasn't included in the dump, now have appeared in it.
ilya-g
added a commit
to JetBrains/kotlin
that referenced
this issue
Nov 17, 2022
There were two problems in BCV fixed: - Kotlin/binary-compatibility-validator#36 - Kotlin/binary-compatibility-validator#58 Therefore some methods with default values and properties that mistakenly wasn't included in the dump, now have appeared in it.
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this issue
Nov 18, 2022
There were two problems in BCV fixed: - Kotlin/binary-compatibility-validator#36 - Kotlin/binary-compatibility-validator#58 Therefore some methods with default values and properties that mistakenly wasn't included in the dump, now have appeared in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When declaring an opt-in annotation and adding that annotation to the
nonPublicMarkers
configuration, functions that have default parameters are not correctly excluded from the api dump - the generated$default
function is still included. A very similar issue to the one fixed in #30.Example annotation:
An example function:
The incorrect API dump:
Project with examples and reproducing the issue can be found here.
The text was updated successfully, but these errors were encountered: