Use defaultPublishConfig if possible for android modules

[pavelreiter]

Fixes #24

I have prepared fix for #24 by adding compileOnly dependency on android gradle plugin (com.android.tools.build:gradle:3.6.4) and using android project extension to fetch defaultPublishConfig as preferred source of compilationName match.

[qwwdfsad]

Thanks

[qwwdfsad]

It seems like defaultPublishConfig is obsolete and recommended way to publish an application with maven-publish plugin is not using it: https://developer.android.com/studio/build/maven-publish-plugin.

I see the alternative solution where the user explicitly states the publication name they want to verify, then, if it's missing, we can lookup defaultPublishConfig and then fallback to release. It would be nice to have a test for that.

The project doesn't have the infrastructure for tests yet (it is coming in #28), so the most valuable contribution would be to just put a bunch of sample Android projects into the resources: with legacy maven plugin, with maven-publish and with library flavours and I will take care of the rest.

[pavelreiter]

Hi, thanks for the comments.
I will try to look into it and since #28 is merged I will try to include some tests.

[kingargyle]

Is there any update on this PR on when it might be addressed. We are looking at using this for our android applications, but will need not only non-release support but flavor support as well. Ideally, the apiDump should support something like, apiDumpDebug, apiDumpFlavorDebug, apiDumpRelease, apiDumpFlavorRelease.

[SumeraMartin]

@pavelreiter @qwwdfsad Hi, are you planning to finish this PR? Or do you have any workaround?

[pavelreiter]

Hi, I am afraid that I have went with metalava for now. I will close the PR.

[SumeraMartin]

I found a hacky workaround. Since I'm using flavors only for changes directly in the code when (BuildConfig.FLAVOR) { ... } and I don't use flavor-specific resources or classes then I'm disabling flavors in build.gradle.kts in case that apiCheck or apiDump task is being executed and I'm adding buildConfigField for FLAVOR with some dummy value. The code will compile fine, the task will succeed and flavors are still in the use. As I said, it is more hack than the correct solution but it works so far.

fun Project.startArgsContains(vararg arguments: String): Boolean {
    val startArgs = project.gradle.startParameter.taskRequests.toString()
    return arguments.any { argument -> startArgs.contains(argument) }
}

android {
    val isKotlinBinaryValidatorTask = project.startArgsContains("apiCheck", "apiDump")

    buildTypes {
        getByName(ProjectSettings.BuildType.DEBUG) {
            ...

            if (isKotlinBinaryValidatorTask) {
                buildConfigField("String", "FLAVOR", "\"dummy\"")
            }
        }
        ...
    }
    
    if (!isKotlinBinaryValidatorTask) {
        flavorDimensions(ProjectSettings.Flavor.DIMENSION)
        productFlavors {
            ...
        }
    }
    ...
}