Evaluate 'static final Companion' visibility in the outer class to th… #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e visibility of the companion class itself Fixes #53
qwwdfsad
commented
Jun 2, 2021
ilya-g
reviewed
Jun 4, 2021
ilya-g
approved these changes
Jun 7, 2021
|
|
||
| // Internal companion is not part of public API | ||
| // neither should be outer static final companion field | ||
| class Companion { |
There was a problem hiding this comment.
Since they share package with the other test declarations, better to name them more specifically, e.g. PublicClassInternalCompanion. Or does it named so to ensure that the object Companion name is not confused with the class Companion name?
There was a problem hiding this comment.
does it named so to ensure that the object Companion name is not confused with the class Companion name?
Right, dropped a comment, renamed non-relevant companions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e visibility of the companion class itself
Fixes #53