-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow writing #162
Arrow writing #162
Conversation
citiesDeserialized["is_capital"] shouldBe citiesExampleFrame["is_capital"] | ||
citiesDeserialized["population"] shouldBe citiesExampleFrame["population"] | ||
citiesDeserialized["area"] shouldBe citiesExampleFrame["area"] | ||
citiesDeserialized["settled"].type() shouldBe typeOf<LocalDate>() // cities["settled"].type() refers to FlexibleTypeImpl(LocalDate..LocalDate?) and does not match typeOf<LocalDate>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, i think it should be fixed in readArrow
later as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FlexibleTypeImpl
comes not from Arrow but from listOf(LocalDate.of())
in the sample generation.
What exactly do you want to fix?
dataframe-arrow/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/ArrowWriter.kt
Show resolved
Hide resolved
Wow, hi! That's a lot of work, thank you for the PR. I'll leave a couple of comments about the details, but right now i seem to lack general understanding, so i'll review it again a bit later. What do you think about making possible warnings a sealed class with overloaded toString for default behaviour? So that you can access actual exception in conversion or DataColumn and KType, etc. |
Sorry, sorry :D I just kept this open while merging other PR and accidentally merged this. Can you re-open? |
It seems that this can not be reopened. Duplicated in #169 by cherry-picking the branch manually. |
Saving DataFrame in Arrow format, as is or per schema.
Warnings are muted by default, this may be changed after #147 resolving.