Sort grouped df #204
Merged
Sort grouped df #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @koperagen the other example from the issue is now also tested and appears to be working correctly |
koperagen
reviewed
Dec 8, 2022
| fun KSDeclaration.getQualifiedNameOrThrow(): String { | ||
| return (qualifiedName ?: error("@DataSchema declaration ${simpleName.asString()} at $location must have qualified name")).asString() | ||
| } | ||
| fun KSDeclaration.getQualifiedNameOrThrow(): String = |
There was a problem hiding this comment.
isn't this commit merged already? is it intentional or something strange happened?
There was a problem hiding this comment.
huh you're right. That's odd. I'll do another rebase and check again
Jolanrensen
force-pushed
the
sort-grouped-df
branch
from
4573665
to
b34a541
Compare
|
okay now I really messed it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress fix for #161.
The first example is now fixed, but for the second example, I might need some test data to be sure it now works as expected.