Parse String column to nullable Double with correct locale #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kopilov
force-pushed
the
cross-nullable-double-convert
branch
from
5960bb4
to
fbd9e6e
Compare
Kopilov
force-pushed
the
cross-nullable-double-convert
branch
from
fbd9e6e
to
016e66d
Compare
Kopilov
force-pushed
the
cross-nullable-double-convert
branch
from
016e66d
to
39b66ed
Compare
|
@zaleslaw please notice that this PR contains test (based on real use case) that does not work originally and patch that fixes it |
|
Yeah, thanks for the comments, I am going to make a review next 2 weeks |
zaleslaw
approved these changes
Apr 18, 2023
|
So, I need to run TC and it will be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have already made system locale considering on parsing String to Double but it worked correctly only when converting nullable to nullable or not nullable to not nullable. This affected writing Arrow per schema in particular.