Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Contribution Guide #250

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Added a Contribution Guide #250

merged 3 commits into from
Feb 6, 2023

Conversation

zaleslaw
Copy link
Collaborator

@zaleslaw zaleslaw commented Feb 2, 2023

Closes #245

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@zaleslaw zaleslaw requested review from koperagen and removed request for Jolanrensen February 3, 2023 13:52
@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label Feb 5, 2023
Copy link
Collaborator

@Jolanrensen Jolanrensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar fixes

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@zaleslaw
Copy link
Collaborator Author

zaleslaw commented Feb 6, 2023

@Jolanrensen thanks a lot for your inspiration about the grammar, I have copied a lot from the KotlinDL guide and was sure that the grammar is ok, need to make a double check in the future before sending on the review

@zaleslaw zaleslaw merged commit e1a2224 into master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Contribution Guide
3 participants