Overload toDataFrame for basic types to avoid surprising results

[koperagen]

Without overloads Iterable.toDataFrame produces unexpected result

val string = listOf("aaa", "aa", null)
string.toDataFrame()

=>
length
0 3
1 2
2 null

I think it will be more reasonable to create a dataframe with a single column for all basic types (numbers, strings, char, boolean), and do reflection scan for everything else

[Jolanrensen]

I agree we need to take care of primitives. A list of strings gives me a dataframe of string lengths without the new overloads haha.
However, do all of these need to be overloads for toDataFrame? Or can these just be moved to createDataFrameImpl?

[koperagen]

I agree we need to take care of primitives. A list of strings gives me a dataframe of string lengths without the new overloads haha. However, do all of these need to be overloads for toDataFrame? Or can these just be moved to createDataFrameImpl?

I don't think so. At east we'll lose the ability to return this typed dataframe

[Jolanrensen]

I agree we need to take care of primitives. A list of strings gives me a dataframe of string lengths without the new overloads haha. However, do all of these need to be overloads for toDataFrame? Or can these just be moved to createDataFrameImpl?

I don't think so. At east we'll lose the ability to return this typed dataframe

Of course! You're right :)

[Jolanrensen]

The rest looks good!
Btw, maybe we should also add overloads for (primitive) arrays toDataFrame, since they aren't iterables

[Jolanrensen]

Could maybe be moved to a separate file, similar to KeyValueProperty :)

[koperagen]

I'd prefer it here, doesn't have much value on its own i think

[Jolanrensen]

thought the same about KeyValueProperty, but who knows, we cannot know everything a user might want :) And a value-only DataSchema seems to me exactly the sort of thing people might want to use (or create themselves)

[koperagen]

The rest looks good! Btw, maybe we should also add overloads for (primitive) arrays toDataFrame, since they aren't iterables

Not sure, so let's return to it later c: I'll merge this