Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs processor #440

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Updating docs processor #440

merged 4 commits into from
Aug 9, 2023

Conversation

Jolanrensen
Copy link
Collaborator

@Jolanrensen Jolanrensen commented Aug 8, 2023

Updating docs preprocessor to 0.2.3 and updating deprecated @tags
@arg -> @setArg and @includeArg -> @getArg as updated by the docs preprocessor.
Also, inheritance is now supported, bringing the operability of [references] in the Gradle plugin closer to how IntelliJ links up references.

I created a pre-commit hook that gets installed locally the first time you assemble the project. This hook runs the doc preprocessor each time you commit something.
One downside is that each commit now takes about 1m30s, but it does come with generated docs safety.

@Jolanrensen Jolanrensen added this to the 0.12.0 milestone Aug 8, 2023
@Jolanrensen Jolanrensen self-assigned this Aug 8, 2023
@Jolanrensen Jolanrensen changed the title Updating docs processor to 0.2.3 and updating deprecated @tags Updating docs processor Aug 9, 2023
@Jolanrensen Jolanrensen marked this pull request as ready for review August 9, 2023 09:59
@koperagen
Copy link
Collaborator

Something with the build :c As for pre-commit hooks, let's see how it works

@@ -157,6 +157,8 @@ tasks.withType<KorroTask> {
// This task installs the pre-commit hook to the local machine the first time the project is built
// The pre-commit hook contains the command to run processKDocsMain before each commit
val installGitPreCommitHook by tasks.creating(Copy::class) {
doNotTrackState(/* reasonNotToTrackState = */ "Fails on TeamCity otherwise.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because TC has a protected/non-existent .git folder

@Jolanrensen Jolanrensen merged commit 9a53196 into master Aug 9, 2023
2 checks passed
@Jolanrensen Jolanrensen deleted the doc-preprocessor-update branch August 9, 2023 12:48
@Jolanrensen Jolanrensen added the KDocs Improvements or additions to KDocs label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KDocs Improvements or additions to KDocs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants