Fix toDataFrame for value classes #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitinas
reviewed
Dec 16, 2023
| class ValueClassConverter(val unbox: Method, val box: Method) | ||
|
|
||
| val valueClassConverter = (it.returnType.classifier as? KClass<*>)?.let { kClass -> | ||
| if (!kClass.isValue) return@let null else { |
There was a problem hiding this comment.
Why do we need explicit return here? This seems readable enough:
if (!kClass.isValue) null else {
There was a problem hiding this comment.
right, thank you
|
|
||
| @Test | ||
| fun valueClassNullableField() { | ||
| val segments = listOf(PathSegment("foo", Speed(2.3)), PathSegment("bar",)) |
There was a problem hiding this comment.
Let's remove trailing comma
There was a problem hiding this comment.
updated formatting here
koperagen
force-pushed
the
fix-toDataFrame-valueclass
branch
from
8fd4763
to
7ac540a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem can be seen here
#526