Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ksp fix #592

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Ksp fix #592

merged 4 commits into from
Feb 19, 2024

Conversation

Jolanrensen
Copy link
Collaborator

Fixes #571 further.

With kotlin.dataframe.add.ksp=false, the user-specified KSP still needs to depend on symbol-processor-all like before. This PR configures KSP regardless of the add.ksp setting.

@Jolanrensen Jolanrensen added the bug Something isn't working label Feb 15, 2024
@Jolanrensen Jolanrensen added this to the 0.13.0 milestone Feb 15, 2024
@Jolanrensen Jolanrensen self-assigned this Feb 15, 2024
@Jolanrensen Jolanrensen marked this pull request as draft February 15, 2024 15:49
@Jolanrensen Jolanrensen marked this pull request as ready for review February 15, 2024 19:52
@Jolanrensen Jolanrensen marked this pull request as draft February 15, 2024 20:16
@Jolanrensen Jolanrensen marked this pull request as ready for review February 16, 2024 15:13
@Jolanrensen
Copy link
Collaborator Author

I updated the KSP version to 1.9.22 ahead of the version bumps.
Last update of KSP in #571 caused KSP to be unaware of @DataSchemas generated by dataframes {} tasks.
This is done by modifying the creation of each individual generateDataFrameX task. Those tasks already added their new src directory to the kotlin sourceSets. While this used to be enough for KSP, it isn't anymore, so now the source is added to the relevant ksp task.
For instance: "build/generated/dataframe/main/kotlin" will be added to kspKotlin and "build/generated/dataframe/test/kotlin" will be added to kspTestKotlin.

@Jolanrensen Jolanrensen mentioned this pull request Feb 19, 2024
@Jolanrensen Jolanrensen merged commit 341365f into master Feb 19, 2024
2 checks passed
@Jolanrensen Jolanrensen deleted the ksp-fix branch February 19, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant