generate "nullable properties" only where needed #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that we generate 4 extension properties for every column has been bothering me for some time now. It makes %trackExecution harder to comprehend, especially considering that we want to improve UX with kernel-generated code on Kotlin Notebook side. After some thinking i came to believe that 4 properties are only needed for declared schemas (like interfaces, or something generated from open api) and thing that bothers me can be solved by adding an option
zaleslaw
approved these changes
Feb 21, 2024
Jolanrensen
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that we generate 4 (and not 2) extension properties for every column has been bothering me for some time now. It makes %trackExecution harder to comprehend, especially considering that we want to improve UX with kernel-generated code on Kotlin Notebook side.
After some thinking i came to believe that 4 properties are only needed for declared schemas (like interfaces, or something generated from open api) and thing that bothers me can be solved by adding an option.