Skip to content

Commit

Permalink
Set default SinceKotlin version for Common to 1.0
Browse files Browse the repository at this point in the history
Avoids the confusion when original 1.0 declarations can be thought of having since kotlin version 1.2 because their common documentation is shown on the first tab.

Common declaration are removed from documentation versions < 1.2 with a different approach - by not configuring a common source set.
  • Loading branch information
ilya-g committed Feb 6, 2023
1 parent d57815e commit ab3bd28
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class SinceKotlinVersion constructor(str: String) : Comparable<SinceKotlinVersio
class SinceKotlinTransformer(val context: DokkaContext) : DocumentableTransformer {

private val minSinceKotlinVersionOfPlatform = mapOf(
Platform.common to SinceKotlinVersion("1.2"),
Platform.common to SinceKotlinVersion("1.0"),
Platform.jvm to SinceKotlinVersion("1.0"),
Platform.js to SinceKotlinVersion("1.1"),
Platform.native to SinceKotlinVersion("1.3")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class SinceKotlinTest : AbstractRenderingTest() {
.children.filter { it.name == "ring" && it is DFunction } as List<DFunction>
with(funcs) {
val sinceKotlin = mapOf(
Platform.common to SinceKotlinVersion("1.2"),
Platform.common to SinceKotlinVersion("1.0"),
Platform.jvm to SinceKotlinVersion("1.0"),
Platform.js to SinceKotlinVersion("1.1"),
Platform.native to SinceKotlinVersion("1.3")
Expand Down

0 comments on commit ab3bd28

Please sign in to comment.