Versioning first draft #1654
Merged
Versioning first draft #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellophane
force-pushed
the
versioning
branch
from
adcd818
to
c8dd76b
Compare
MarcinAman
reviewed
Dec 3, 2020
sellophane
force-pushed
the
versioning
branch
from
c8dd76b
to
f66e084
Compare
MarcinAman
approved these changes
Dec 16, 2020
plugins/versioning/src/main/kotlin/versioning/ReplaceVersionCommandConsumer.kt
Show resolved
Hide resolved
| private fun handlePreviousVersions(olderDokkaPath: File, output: File) { | ||
| assert(olderDokkaPath.isDirectory) { "Supplied previous version $olderDokkaPath is not a directory!" } | ||
| val children = olderDokkaPath.list().orEmpty().map { olderDokkaPath.resolve(File(it)) } | ||
| val oldVersion = children.first { it.name == VERSIONS_FILE }.let { file -> |
There was a problem hiding this comment.
firstOrNull + some message if not found since it will be super hard to debug later
...ers/gradle-plugin/src/test/kotlin/org/jetbrains/dokka/gradle/AndroidAutoConfigurationTest.kt
Outdated
Show resolved
Hide resolved
sellophane
force-pushed
the
versioning
branch
4 times, most recently
from
682eb78
to
897f223
Compare
sellophane
force-pushed
the
versioning
branch
from
897f223
to
53cb63f
Compare
kamildoleglo
suggested changes
Dec 28, 2020
Comment on lines
+47
to
+51
| configuration<VersioningPlugin, VersioningConfiguration>(context)?.let { | ||
| group(extra = PropertyContainer.withAll(InsertTemplateExtra(ReplaceVersionsCommand))) { } | ||
| } |
There was a problem hiding this comment.
This should check if the plugin is on the classpath or log a debug that the plugin will not be used
plugins/all-modules-page/src/test/kotlin/templates/ResolveLinkCommandResolutionTest.kt
Outdated
Show resolved
Hide resolved
plugins/all-modules-page/src/test/kotlin/templates/ResolveLinkGfmCommandResolutionTest.kt
Outdated
Show resolved
Hide resolved
plugins/all-modules-page/src/test/kotlin/templates/mockedPackageListFactory.kt
Outdated
Show resolved
Hide resolved
plugins/base/base-test-utils/src/main/kotlin/utils/assertHtmlEqualsIgnoringWhitespace.kt
Outdated
Show resolved
Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt
Outdated
Show resolved
Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt
Outdated
Show resolved
Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt
Outdated
Show resolved
Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt
Outdated
Show resolved
Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt
Outdated
Show resolved
Hide resolved
sellophane
force-pushed
the
versioning
branch
from
53cb63f
to
90a2987
Compare
sellophane
force-pushed
the
versioning
branch
from
90a2987
to
f627cab
Compare
MarcinAman
force-pushed
the
versioning
branch
from
113f14d
to
386ca81
Compare
This was referenced Mar 15, 2021
Bump dokka-maven-plugin from 1.4.20-dev-65 to 1.4.30 in /officefloor/bom
officefloor/OfficeFloor#915
Merged
This was referenced Mar 16, 2021
[Dependency]: Bump dokka-gradle-plugin from 0.10.1 to 1.4.30
PatilShreyas/EasyUpiPayment-Android#100
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.