Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning first draft #1654

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Versioning first draft #1654

merged 5 commits into from
Jan 5, 2021

Conversation

sellophane
Copy link
Contributor

No description provided.

@sellophane sellophane marked this pull request as draft December 2, 2020 05:49
MarcinAman
MarcinAman reviewed Dec 3, 2020
View reviewed changes
Copy link
Contributor

@MarcinAman MarcinAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic here is correct my only complain is that i feel it should be a plugin to decouple functionalities. I don't expect everyone using multimodule to use versions, in fact this is a quite niche behaviour

MarcinAman
MarcinAman approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@MarcinAman MarcinAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can i ask you to make 1, very simple integration test?

plugins/versioning/src/main/kotlin/versioning/ReplaceVersionCommandConsumer.kt Show resolved Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt Outdated
private fun handlePreviousVersions(olderDokkaPath: File, output: File) {
assert(olderDokkaPath.isDirectory) { "Supplied previous version $olderDokkaPath is not a directory!" }
val children = olderDokkaPath.list().orEmpty().map { olderDokkaPath.resolve(File(it)) }
val oldVersion = children.first { it.name == VERSIONS_FILE }.let { file ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firstOrNull + some message if not found since it will be super hard to debug later

...ers/gradle-plugin/src/test/kotlin/org/jetbrains/dokka/gradle/AndroidAutoConfigurationTest.kt Outdated Show resolved Hide resolved
@sellophane sellophane force-pushed the versioning branch 4 times, most recently from 682eb78 to 897f223 Compare December 21, 2020 17:07
@sellophane sellophane marked this pull request as ready for review December 28, 2020 09:53
kamildoleglo
kamildoleglo suggested changes Dec 28, 2020
View reviewed changes
plugins/all-modules-page/src/main/kotlin/MultimodulePageCreator.kt
Comment on lines +47 to +51
configuration<VersioningPlugin, VersioningConfiguration>(context)?.let {
group(extra = PropertyContainer.withAll(InsertTemplateExtra(ReplaceVersionsCommand))) { }
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should check if the plugin is on the classpath or log a debug that the plugin will not be used

plugins/all-modules-page/src/test/kotlin/templates/ResolveLinkCommandResolutionTest.kt Outdated Show resolved Hide resolved
plugins/all-modules-page/src/test/kotlin/templates/ResolveLinkGfmCommandResolutionTest.kt Outdated Show resolved Hide resolved
plugins/all-modules-page/src/test/kotlin/templates/mockedPackageListFactory.kt Outdated Show resolved Hide resolved
plugins/base/base-test-utils/src/main/kotlin/utils/assertHtmlEqualsIgnoringWhitespace.kt Outdated Show resolved Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt Outdated Show resolved Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt Outdated Show resolved Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt Outdated Show resolved Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt Outdated Show resolved Hide resolved
plugins/versioning/src/main/kotlin/versioning/VersioningHandler.kt Outdated Show resolved Hide resolved
@MarcinAman MarcinAman merged commit 1618e55 into master Jan 5, 2021
@MarcinAman MarcinAman deleted the versioning branch January 5, 2021 16:59
@MarcinAman MarcinAman mentioned this pull request Feb 9, 2021
Closed
This was referenced Mar 15, 2021
Merged
Merged
Merged
Merged
Merged
Closed
Closed
This was referenced Mar 16, 2021
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamildoleglo kamildoleglo kamildoleglo requested changes

@MarcinAman MarcinAman MarcinAman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sellophane @kamildoleglo @MarcinAman