JvmOverloads #1712
Merged
JvmOverloads #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(cc @MarcinAman, this is the first PR, I'll try to do the |
kamildoleglo
suggested changes
Jan 31, 2021
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinToJavaConverter.kt
Outdated
Show resolved
Hide resolved
MarcinAman
approved these changes
Feb 1, 2021
kamildoleglo
approved these changes
Feb 4, 2021
|
Thanks |
This was referenced Mar 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds
JvmOverloadssupport by generating the required functions.As
DFunction.asJavawas modified, I took the liberty of also fixing the fact that top-level functions weren't marked as static.