Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsoup to 1.15.3 to mitigate against CVE vulnerability #2754

Closed
ryanlewis opened this issue Nov 25, 2022 · 1 comment · Fixed by #2772
Closed

Upgrade jsoup to 1.15.3 to mitigate against CVE vulnerability #2754

ryanlewis opened this issue Nov 25, 2022 · 1 comment · Fixed by #2772
Labels
enhancement An issue for a feature or an overall improvement

Comments

@ryanlewis
Copy link
Contributor

Bump jsoup to 1.15.3 to mitigate against CVE-2022-36033.

A quick local test seemed to suggest that simply bumping the version breaks the build, when attempted locally.

@ryanlewis ryanlewis added the enhancement An issue for a feature or an overall improvement label Nov 25, 2022
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Dec 13, 2022

Thanks for bringing this up and attempting to fix it on your own!

simply bumping the version breaks the build

yeah, Jsoup has the following class:

class Elements extends ArrayList<Element>

and we used Kotlin's List.filter extension on it in tests:

elements.filter { ... }

However, it looks like jsoup 1.15 brings a new method to this class, which interferes with the Kotlin extension:

public Elements filter(NodeFilter nodeFilter) {
    NodeTraversor.filter(nodeFilter, this);
    return this;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An issue for a feature or an overall improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants