Make MarkdownParser output text instead of broken links #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want this being merged into 1.4.0? |
sellmair
reviewed
Aug 20, 2020
| } | ||
|
|
||
| private fun String.isRemoteLink() = try { | ||
| URL(this) |
There was a problem hiding this comment.
I was looking for some more straight-forward way of checking this.
@Kordyjan Do you know a better method? 🙄
There was a problem hiding this comment.
I think this is the way many people do this. It's not the nicest API, but seems to work for others as well 🤷
Not sure 🤔 We can do that I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarkdownParser should also output info about the unresolved link and its location. This however should be done properly when refactoring the parser
Closes #1345