Annotations for parameters #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamildoleglo
suggested changes
Feb 3, 2021
...ns/base/src/main/kotlin/translators/descriptors/DefaultDescriptorToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/translators/psi/DefaultPsiToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
| extra = annotations() | ||
| ) | ||
| else -> GenericTypeConstructor( | ||
| DRI.from(ctor!!), // TODO: remove '!!' |
There was a problem hiding this comment.
The !! can be removed here IMHO
There was a problem hiding this comment.
I dont think so since it is nullable and afaik we dont have a nullable constructor for DRI
|
Minor comments, otherwise good to go. Not sure about the naming, although IMHO it's ok, any better ideas @Kordyjan? |
|
|
MarcinAman
force-pushed
the
annotations_on_bounds
branch
from
d144634
to
17adfaa
Compare
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name
Annotatableis up to discussion, i am not entirely happy with it