Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotkey for opening search dialog #2633

merged 3 commits into from Aug 24, 2022

Add hotkey for opening search dialog #2633

merged 3 commits into from Aug 24, 2022


Copy link

@atyrin atyrin commented Aug 21, 2022

Add a Cmd + K/Ctrl + K hotkey for opening the search window.

  • Meta key Cmd/Ctrl depends on OS. For macOS -- Cmd, for every other -- Ctrl.

  • The search button have a tooltip with the name of key combination. The tooltip appears after 500 ms on mouse over.

  • The combination prevents default hotkey actions like the or behave. E.g. the Cmd+K combination is default option to focus on the omnibox in Firefox.

  • Tested on Chrome/Filefox/Safary on macOS, on Edge/Firefox on Windows

Fix #2265

Copy link
Contributor Author

atyrin commented Aug 22, 2022

There is an issue, that the hotkey will be triggered even if the key combination is a subset of another key combination (e.g. Cmd + Shift + K)

Copy link

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Especially the tooltip :)

@vmishenev vmishenev merged commit 56beaa3 into master Aug 24, 2022
@vmishenev vmishenev deleted the search-hotkey branch August 24, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Hotkey to open HTML search
3 participants