Suppress useless companion for Kotlin-As-Java #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* hide companion object if it contains only const/lateinit/@JvmField properties or @JvmStatic functions * lift the declarations to outer class from companion * mark lifted declarations as static * mark const/JvmField/lateinit properties as static for named objects
* remove getter/setter for lifted from companion properties and named objects * fix visibility modifiers for lifter properties * fix always public top level constants
If a companion object rendered for the class then the static property for accessing the object is shown.
zarechenskiy
previously requested changes
Sep 27, 2022
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinCompanion.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinCompanion.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinCompanion.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinCompanion.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinCompanion.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinCompanion.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinToJavaConverter.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinToJavaConverter.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinToJavaConverter.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinToJavaConverter.kt
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinCompanion.kt
Outdated
Show resolved
Hide resolved
IgnatBeresnev
approved these changes
Oct 18, 2022
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinToJavaConverter.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin-as-java/src/main/kotlin/converters/KotlinCompanion.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const/@JvmField/lateinitproperties or@JvmStaticfunctionsconst/@JvmField/lateinitproperties as static for named objectsconst/lateinitproperties in named objects/companionsFix #200, fix #2086