Update tested versions for integration tests #2739
Conversation
| @@ -17,7 +17,7 @@ class StdlibGradleIntegrationTest(override val versions: BuildVersions) : Abstra | |||
| @get:JvmStatic | |||
| @get:Parameterized.Parameters(name = "{0}") | |||
| val versions = BuildVersions.permutations( | |||
| gradleVersions = listOf("5.6"), | |||
| gradleVersions = listOf("6.7.1"), | |||
There was a problem hiding this comment.
This is the main change and reason for this PR. Looks like Gradle 5 does not support Kotlin DSL plugin, see #2702
I think our minimum supported Gradle version should be the same as in KGP, which is 6.7.1, so there's no point testing against 5.6
| gradleVersions = listOf("7.4.2", *ifExhaustive("7.0")), | ||
| androidGradlePluginVersions = listOf("7.3.0"), | ||
| gradleVersions = listOf("7.5.1"), | ||
| kotlinVersions = listOf("1.7.20", "1.6.21", "1.5.31", "1.4.32"), | ||
| androidGradlePluginVersions = listOf("7.2.0") | ||
| ) + BuildVersions.permutations( | ||
| gradleVersions = listOf("6.9", *ifExhaustive("6.1.1", "5.6.4")), | ||
| androidGradlePluginVersions = listOf("4.2.0"), | ||
| gradleVersions = listOf("6.7.1"), | ||
| kotlinVersions = listOf("1.7.20", "1.6.21", "1.5.31", "1.4.32"), | ||
| androidGradlePluginVersions = listOf("4.0.0", *ifExhaustive("3.6.3")) | ||
| ) + BuildVersions.permutations( | ||
| androidGradlePluginVersions = listOf(*ifExhaustive("3.6.4")), | ||
| gradleVersions = listOf(*ifExhaustive("6.7.1")), | ||
| kotlinVersions = listOf(*ifExhaustive("1.7.20", "1.6.21", "1.5.31", "1.4.32")), |
There was a problem hiding this comment.
Made some changes which should hopefully be compatible. This may help repair isExhaustive flagged runs.
- Latest AGP with latest Gradle and supported Kotlin versions. Version 7 of AGP works with Gradle 7 only
- Previous major AGP version with its supported Gradle version (AGP 4.2+ works with Gradle 6.7)
- Really old version of AGP, not sure if it'll work
|
The tests in #2702 are now passing - so perhaps this PR isn't needed? Although dropping support for ancient Gradle versions is not a bad thing! |
|
There will be merge conflicts after updating to 1.8.0, and it should be revisited after merging #2841 anyway, so I'm closing it for now, but will either re-open it or make a new one after the 1.8.10 release. |
No description provided.