Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mobile view and some bugs #2836

Merged
merged 28 commits into from
May 24, 2023
Merged

update mobile view and some bugs #2836

merged 28 commits into from
May 24, 2023

Conversation

zoobestik
Copy link
Contributor

@zoobestik zoobestik commented Jan 31, 2023

Link to live demo πŸš€

Fix bugs βœ…:

  • sidebar is white in dark theme
  • logo and filter diffusion in mobile view
  • white border
  • update header icons
  • update labels with platforms
  • more space in mobile view
  • fix sidebar and content bottom scroll
  • fix code blocks with long token
  • playground re-init bug
  • dark style for blockquote
  • add spacing for sam code samples
  • update brand color to a11y compatible

Updated header view πŸ–ΌοΈ:

Screenshot 2023-01-31 at 01 27 43

Screenshot 2023-01-31 at 01 28 04

Issues photos 🐞:

see photos Screenshot 2023-01-31 at 01 34 30 Screenshot 2023-01-31 at 01 36 07

@zoobestik zoobestik marked this pull request as ready for review February 1, 2023 12:47
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Feb 6, 2023

It's awesome that Dokka can be run without JS and still look like a functioning website now! It was confusing for people to open Dokka pages as files in their browser and see no navigation menu, as demonstrated by #1588 and #1513. With the changes from this PR, it will not look broken, but people might still question why there is no navigation menu or why some things do not work.

It's totally optional, but is it possible to add an indicator or a hint or a banner (or anything else) that will say something like

JavaScript is not enabled on this page, some content or functionality of the website can be limited or unavailable.

If you are opening local .html files in your browser, to fix this please use a web server to host documentation, or use the IntelliJ Ultimate built-in web server for preview."

Created a separate issue for this: #2964


Also, if it's not too much to ask, can you disable showing this "copy anchor" popup if JS is disabled? It's not going to work if it's pressed. Hover over any function/property name from the left column

2023-02-06_00-54-29

@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Feb 6, 2023

And a question on the source set buttons in the header.

I don't know if it's a bug in my browser or if it's intended, but on wide monitors the buttons look huge and have a different shape (rounded corners). It's especially strange to see when you're looking at the page with packages that have the same source set indicators, but in a different shape

Screenshot

2023-02-06_00-31-43


However, if I shrink the page horizontally, the buttons change their shape and are smaller, which is nice. Can we stick to one style and size only (the one below)?

Screenshot

2023-02-06_00-31-54


Also, the buttons themselves are quite confusing, it's not clear what their purpose is and how they help the reader, ideally we want to redesign it completely (see #2779). For this reason, maybe it makes sense to make them smaller to not draw so much attention? What do you think?

Copy link
Contributor

@nikpachoo nikpachoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not easy work, thank you!
Nothing critical, just a few comments.

@IgnatBeresnev IgnatBeresnev linked an issue Mar 8, 2023 that may be closed by this pull request
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Apr 17, 2023

Created a separate issue for my no-JS indicator proposal: #2964

@zoobestik zoobestik changed the title WIP: update mobile view and some bugs update mobile view and some bugs May 17, 2023
@IgnatBeresnev IgnatBeresnev linked an issue May 19, 2023 that may be closed by this pull request
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome πŸ‘πŸ‘

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome πŸ‘πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML: Sidebar not visible on mobile [BUG] HTML output doesn't work well in mobile
3 participants