Improve JavadocParser and fix case-sensitivity #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get rid of safeEnumValueOf that was an unnecessary public API burden and constantly allocating * Restructure JavadocParser.parseDocTag so it has one lever of nesting less * Make tag parsing case-sensitive Fixes #2907
qwwdfsad
force-pushed
the
get-rid-of-obsolete-api
branch
from
f6fd2ad
to
7b6e30f
Compare
qwwdfsad
changed the title
vmishenev
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
It would be great to have a test (e.g. in JavadocParserTest.kt).
By the way, for KDoc there is the different behaviour
|
Nice one, filed #2929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2907