Update Kotlin compiler to 1.8.20 #3062
Conversation
vmishenev
force-pushed
the
update-kotlin-compiler-1.8.20
branch
from
4673d21
to
80fc13b
Compare
vmishenev
force-pushed
the
update-kotlin-compiler-1.8.20
branch
from
80fc13b
to
523dbb8
Compare
vmishenev
changed the title
vmishenev
force-pushed
the
update-kotlin-compiler-1.8.20
branch
from
523dbb8
to
0130109
Compare
vmishenev
force-pushed
the
update-kotlin-compiler-1.8.20
branch
from
0130109
to
66cfe58
Compare
vmishenev
force-pushed
the
update-kotlin-compiler-1.8.20
branch
from
5a5cb9a
to
79c74c3
Compare
| @@ -528,7 +530,14 @@ class AnalysisEnvironment( | |||
| } | |||
|
|
|||
| // Set up JDK classpath roots explicitly because of https://github.com/JetBrains/kotlin/commit/f89765eb33dd95c8de33a919cca83651b326b246 | |||
| internal fun configureJdkClasspathRoots() = configuration.configureJdkClasspathRoots() | |||
There was a problem hiding this comment.
Was this function removed from the compiler with no replacement, or what was the motivation to copy paste the body?
There was a problem hiding this comment.
What do you mean? Whose body?
It copies nothing.
configuration.configureJdkClasspathRoots() still exists, it is used here too.
There was a problem hiding this comment.
I don't understand where the rest of the new code in this function came from, and why it's needed :) As far as I can see, the called compiler function already checks for java.home
There was a problem hiding this comment.
I don't understand where the rest of the new code in this function came from, and why it's needed :)
It's needed for https://github.com/JetBrains/kotlin/blob/45b1c33ed8a33c92207d1bd9f2e83738995836ae/compiler/cli/cli-base/src/org/jetbrains/kotlin/cli/jvm/compiler/KotlinCoreEnvironment.kt#L208 (support modular JDK)
The compiler does the same here
As far as I can see, the called compiler function already checks for java.home
It does not put JVMConfigurationKeys.JDK_HOME in the configuration.
...nalysis/kotlin/descriptors/compiler/configuration/resolve/DokkaJsResolverForModuleFactory.kt
Outdated
Show resolved
Hide resolved
(cherry picked from commit 19d287f)
No description provided.