Get rif of IDE plugin dependencies #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything in this commit has been copy-pasted from IDE plugin and marked as internal
vmishenev
commented
Jul 13, 2023
|
|
||
| @Suppress("UNCHECKED_CAST") | ||
| val resolution = CompilerExtensionPointProvider.CompilerExtensionPoint( |
There was a problem hiding this comment.
In K1 IdePlatformKindResolution is used to configure global caches to analyze code for different platforms. It contains platform factories, they are used in IdeaResolverForProject and in the inheritors of ResolverForModuleFactory for different platforms to create some components for the frontend: biltins, package providers for Klib'as and fabrics for creating classes...
But IdeaResolverForProject is not used in Dokka,
KotlinCacheService we have our own stub,
ResolverForModuleFactory we have our own inheritors, where PlatformKindResolution is not called.
IgnatBeresnev
approved these changes
Jul 17, 2023
...lin/org/jetbrains/dokka/analysis/kotlin/descriptors/ide/IdeCompilerExtensionPointProvider.kt
Outdated
Show resolved
Hide resolved
...e/src/main/kotlin/org/jetbrains/dokka/analysis/kotlin/descriptors/ide/IdeDescriptorFinder.kt
Outdated
Show resolved
Hide resolved
vmishenev
force-pushed
the
get-rid-of-ide-plugin-dependencies
branch
from
893a4b6
to
13a7629
Compare
IgnatBeresnev
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Get rif of IDE plugin dependencies Everything in this commit has been copy-pasted from IDE plugin and marked as internal (cherry picked from commit 298065f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything in this commit has been copy-pasted from IDE plugin and marked as internal