Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Wrap links and code blocks #3415

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

lauzadis
Copy link
Contributor

@lauzadis lauzadis commented Dec 15, 2023

Wrap links and code blocks to prevent two-dimensional scrollbar from appearing on small screens.

Solves violation number 5 in this issue: #3414

Copy link
Contributor

@berezinant berezinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lauzadis, I've tested it and this definitely makes things better!

However there are some other cases when two dimensional scroll still preserves
image

Would you prefer to fix such cases in this PR?

e.g. adding something like word-break: break-word could lead to such picture
image

/cc @IgnatBeresnev

@lauzadis
Copy link
Contributor Author

Sorry for my delayed response, I was not notified there was activity on these!

I added word-break: break-word and renamed word-wrap->overflow-wrap as recommended. Thanks!

@berezinant berezinant merged commit 5ae6610 into Kotlin:master Apr 16, 2024
6 checks passed
@lauzadis lauzadis deleted the accessibility-reflow branch April 17, 2024 13:53
@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Apr 25, 2024
@IgnatBeresnev IgnatBeresnev added the format: html An issue/PR related to Dokka's default HTML output format label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format: html An issue/PR related to Dokka's default HTML output format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants