Update Maven Integration Tests to use JVM Test Suites #3581
+471
−342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate the CLI integration tests away from the custom integration test convention (which are not build-cache compatible) to use JVM Test Suites.
- Remove shadowing, replace with passing in the JARs via system properties. (a custom CommandLineArgumentProvider is confusing and overly complicated, but it's required to satisfy Gradle input normalization, so that the build-cache can be re-used.)
- Simplify `processUtils.kt` - the coroutines logic isn't necessary since the entrypoint just used `runBlocking {}`.
- move `jsonBuilder.kt` test-util into `src/main`, since it's not a test
- Rename `CliIntegrationTest` to `CliTest` (it wasn't an integration test, and the name was confusing compared to the actual `CliIntegrationTest`)
… re-write a shared file in resources
Part of KT-64200 WIP
adam-enko
force-pushed
the
KT-64200/maven-jvm-test-suite
branch
from
8b6dba6
to
16278e0
Compare
adam-enko
changed the title
…aven-jvm-test-suite
adam-enko
force-pushed
the
KT-64200/maven-jvm-test-suite
branch
from
e4cddd5
to
5a63254
Compare
- Re-introduce shared integration-test convention plugin, to de-duplicate common IT config. - Add util for adding system properties & registering the values as appropriate Gradle task inputs. (This required replacing env-vars with system props.)
whyoleg
approved these changes
Jun 5, 2024
Refactor `fun MutableList<CommandLineArgumentProvider>.systemProperty()` to be more consistent with the other systemProperty utils, and so the intention is clearer.
adam-enko
force-pushed
the
KT-64200/maven-jvm-test-suite
branch
from
0939e5d
to
b887dc5
Compare
ALikhachev
approved these changes
Jun 18, 2024
whyoleg
reviewed
Jun 18, 2024
build-logic/src/main/kotlin/dokkabuild/DevMavenPublishExtension.kt
Outdated
Show resolved
Hide resolved
| * because such a property might disrupt task caching.) | ||
| * | ||
| * If you want to register the property as a Task input, use the | ||
| * [Test.systemProperty][dokkabuild.utils.systemProperty] above instead. |
There was a problem hiding this comment.
Sorry, how do you think it could be rephrased?
There was a problem hiding this comment.
I mean, it's now a function inside an object which is created by [Test.systemProperty], so may be suggesting just using other property will be more appropriate here, like:
Suggested change
| * [Test.systemProperty][dokkabuild.utils.systemProperty] above instead. | |
| * [inputProperty] above instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KT-64200
Updates
dokka-integration-tests/mavento use jvm-test-suitesDe-duplicates integration-test configuration into the
dokkabuild.test-integration.gradle.ktsconvention plugin.integrationTesttocliIntegrationTestto avoid clashing with theintegrationTestlifecycle task.Implement a new utility for passing in system properties to test tasks, and correctly registering them as Gradle inputs.
Using System Properties is preferred to environment variables, because they are easier to register as Gradle task inputs.