-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding a Dokka version in integration tests #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can indeed come in handy 👍
whyoleg
force-pushed
the
it-custom-dokka-version
branch
from
May 7, 2024 05:58
199d6be
to
6dbe661
Compare
whyoleg
commented
May 8, 2024
berezinant
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it, works well both with published and local versions of Dokka 👍
adam-enko
requested changes
May 13, 2024
...-tests/gradle/src/main/kotlin/org/jetbrains/dokka/it/gradle/AbstractGradleIntegrationTest.kt
Outdated
Show resolved
Hide resolved
...-tests/gradle/src/main/kotlin/org/jetbrains/dokka/it/gradle/AbstractGradleIntegrationTest.kt
Outdated
Show resolved
Hide resolved
adam-enko
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An addition for #3583.
For UI showcase project, after PR is merged, it will be possible to run it like this:
It's also possible to add
org.jetbrains.dokka.integration_test.dokkaVersionOverride=2.0.0-dev-329
todokka-integration-tests/gradle.properties
(but, it's less recommended, as it could be unnoticed and affect tests behaviour)Note: PR is based on master and not
ui-test-project
branch, sotestUiShowcaseProject
will be not available.Note regarding implementation:
ui-showcase
project. Additionally it could be useful for reproducing bugs with older versions if needed via just property;project.version
to overrideDOKKA_VERSION
and then do the logic based on it - but it will cause rebuilding of all artefacts (because ofdevMavenPublish
). It's possible to overcome this, but I didn't want to change a lot of code;DOKKA_VERSION
for detecting some override could cause some unknown issues;additive
change for this specific use case.