Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JetBrains cache-redirector #3650

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Use JetBrains cache-redirector #3650

merged 10 commits into from
Jun 27, 2024

Conversation

adam-enko
Copy link
Contributor

@adam-enko adam-enko commented Jun 19, 2024

Use JetBrains cache-redirector in Dokka build, Gradle integration tests, and Maven integration tests.

Update the Gradle Wrapper task to use the cache-redirector too, and add an explanation.

Part of KT-64200

@adam-enko adam-enko force-pushed the KT-64200/jb-cache-redirector branch from d395938 to 44b9d30 Compare June 19, 2024 10:57
@adam-enko adam-enko marked this pull request as ready for review June 20, 2024 09:13
Copy link
Contributor

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be nice to leave a small comment on how to update Gradle wrapper now

build.gradle.kts Outdated


tasks.wrapper {
val gradleVersion = "8.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to clarify: after PR merged to update the version of Gradle, we need:

  1. set gradleVersion to the new value
  2. go to https://gradle.org/release-checksums/ and copy the checksum
  3. set distributionSha256Sum to the new value
  4. run gradle wrapper

correct?

Previously it was just gradle wrapper --gradle-version=8.8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will double check and document the steps. Normally I update gradle.properties but yes, there are multiple ways.

Previously it was just gradle wrapper --gradle-version=8.8

And then re-run gradle wrapper, otherwise the wrapper scripts won't be updated 🙃

Copy link
Contributor Author

@adam-enko adam-enko Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL how to update Gradle (while using distributionSha256Sum). It is not simple :(

Hopefully the instructions are clear - WDYT?

@adam-enko
Copy link
Contributor Author

LGTM, would be nice to leave a small comment on how to update Gradle wrapper now

Very good idea, I will do that.

@adam-enko adam-enko added the infrastructure Everything related to builds tools, CI configurations and project tooling label Jun 27, 2024
@adam-enko adam-enko merged commit 95be9d6 into master Jun 27, 2024
14 checks passed
@adam-enko adam-enko deleted the KT-64200/jb-cache-redirector branch June 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Everything related to builds tools, CI configurations and project tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants