Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to translate generic params when default values are not type params #129

Closed
Schahen opened this issue Oct 10, 2019 · 1 comment
Closed

Failing to translate generic params when default values are not type params #129

Schahen opened this issue Oct 10, 2019 · 1 comment
Labels
translation-failure failed with exception while translating

Comments

@Schahen
Copy link
Contributor

Schahen commented Oct 10, 2019

This code:

declare interface TriggeredEvent<
    TDelegateTarget = any,
    TData = any,
    TCurrentTarget = any,
    TTarget = any 
>{}

declare interface EventHandlerBase<TContext, T> {}

declare type EventHandler<
    TCurrentTarget,
    TData = undefined
> = EventHandlerBase<TCurrentTarget, TriggeredEvent<TCurrentTarget, TData>>;

Will fail to compile
This was introduced in 4c35e07 - but it's not regression rather some uncovered case
@Schahen Schahen added bug translation-failure failed with exception while translating labels Oct 10, 2019
@Schahen Schahen changed the title Failing to translated nested generic params Failing to translated generic params when default values are not type params Oct 10, 2019
@Schahen Schahen changed the title Failing to translated generic params when default values are not type params Failing to translate generic params when default values are not type params Oct 10, 2019
Schahen added a commit that referenced this issue Oct 10, 2019
@Schahen
Failing to translate generic params with default values when such val…
df3a6c6 
…ues are not type params

see #129
@Schahen
Copy link
Contributor Author

Schahen commented Oct 10, 2019

fixed in v0.0.20

@Schahen Schahen closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
translation-failure failed with exception while translating
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Schahen