Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Suppress(EXTERNAL_DELEGATION) only where we actually need it #329

Closed
Schahen opened this issue Jul 9, 2020 · 1 comment
Closed

Add Suppress(EXTERNAL_DELEGATION) only where we actually need it #329

Schahen opened this issue Jul 9, 2020 · 1 comment
Labels
better-translation Code is translated and even useable, but can be better
Milestone

Comments

@Schahen
Copy link
Contributor

Schahen commented Jul 9, 2020

We're adding EXTERNAL_DELEGATION suppression on a file level while actually we can add it exactly where it's needed, like we do with NESTED_CLASS_IN_EXTERNAL_INTERFACE. In other words this:

@file:Suppress("INTERFACE_WITH_SUPERCLASS", "OVERRIDING_FINAL_MEMBER", "RETURN_TYPE_MISMATCH_ON_OVERRIDE", "CONFLICTING_OVERLOADS", "EXTERNAL_DELEGATION")

@Suppress("NESTED_CLASS_IN_EXTERNAL_INTERFACE")
external interface MySymbol {
     companion object : MySymbolConstructor by definedExternally
}

can be just

@file:Suppress("INTERFACE_WITH_SUPERCLASS", "OVERRIDING_FINAL_MEMBER", "RETURN_TYPE_MISMATCH_ON_OVERRIDE", "CONFLICTING_OVERLOADS")

@Suppress("NESTED_CLASS_IN_EXTERNAL_INTERFACE",  "EXTERNAL_DELEGATION")
external interface MySymbol {
     companion object : MySymbolConstructor by definedExternally
}
@Schahen Schahen added the better-translation Code is translated and even useable, but can be better label Jul 9, 2020
@Schahen Schahen added this to the 0.5.6 milestone Jul 9, 2020
@Schahen
Copy link
Contributor Author

Schahen commented Jul 13, 2020

Released in 0.5.6

@Schahen Schahen closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-translation Code is translated and even useable, but can be better
Projects
None yet
Development

No branches or pull requests

1 participant