Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional version tag to use directive #70

Closed
altavir opened this issue May 26, 2020 · 0 comments · Fixed by #89
Closed

Add optional version tag to use directive #70

altavir opened this issue May 26, 2020 · 0 comments · Fixed by #89
Labels
feature

Comments

@altavir
Copy link
Contributor

altavir commented May 26, 2020

Currently, use uses current version of the module descriptor from the distribution or the web. As it is, it solve significant portion of the problem with notebook reproducability, but sooner or later we will move to newer versions of artifacts mentioned in use and old notebooks could stop working.

I propose to add a version/variant qualifier to the module name like kmath@0.1.3 (any other symbol could be used instead of @. Different version of the module descriptor could be stored in the same file and if no qualifier is provided, resolver should default empty one. Also it is possible to introduce nested qualifiers in case we will need something more complicated: kmath@dev@0.1.4-dev-2 (default dev version is provided for kmath@dev). Nested descriptors are quite easy to do with json.
ileasile added a commit that referenced this issue Jul 22, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
24181a6 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
@ileasile ileasile mentioned this issue Jul 22, 2020
Merged
ileasile added a commit that referenced this issue Jul 22, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
595c25a 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 22, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
bdbfc6a 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 23, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
d48e3a3 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 23, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
36dd0b3 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 23, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
5f06a78 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 23, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
22d3606 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 24, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
2bc900e 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 25, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
5e6f878 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 26, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
0f1e9d3 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 26, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
32a4e84 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 27, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
596389e 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 27, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
152180b 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 27, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
8d832cf 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 27, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
5cd2afb 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 27, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
a545815 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 28, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
6948c60 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Jul 28, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
9dec2e5 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Aug 3, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
ddfa05f 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Aug 18, 2020
@ileasile
Refactor libraries handling, add handling of descriptors
ac22831 
from different sources.

Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.
ileasile added a commit that referenced this issue Aug 18, 2020
@ileasile
Refactor libraries handling, add handling of descriptors from differe…
4175906 
…nt sources (#89)

* Refactor libraries handling, add handling of descriptors
from different sources. Fixes #70

Also, get rid of several singletons in config and replaced
them with factory and free functions.

* Pass repl as evaluation parameter on configuration creation
* Update project dictionary
* Add local Maven repository if it exists
* Add default resolution info detection heuristics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
2 participants
@altavir @ileasile