Flag for Native IR integration tests #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvicsokolova
force-pushed
the
integration-tests
branch
from
fd3ad7a
to
ea02a32
Compare
mvicsokolova
force-pushed
the
native-ir-flag-with-integration-tests
branch
5 times, most recently
from
d366187
to
543f0b1
Compare
mvicsokolova
force-pushed
the
native-ir-flag-with-integration-tests
branch
from
543f0b1
to
28c7762
Compare
|
Rebased on the fresh |
fzhinkin
requested changes
Nov 14, 2023
...nctionalTest/kotlin/kotlinx.atomicfu.gradle.plugin.test/framework/checker/ArtifactChecker.kt
Outdated
Show resolved
Hide resolved
...nctionalTest/kotlin/kotlinx.atomicfu.gradle.plugin.test/framework/checker/ArtifactChecker.kt
Show resolved
Hide resolved
...onalTest/kotlin/kotlinx.atomicfu.gradle.plugin.test/framework/checker/DependenciesChecker.kt
Outdated
Show resolved
Hide resolved
fzhinkin
reviewed
Nov 14, 2023
...esting/src/functionalTest/kotlin/kotlinx.atomicfu.gradle.plugin.test/cases/MppProjectTest.kt
Outdated
Show resolved
Hide resolved
fzhinkin
approved these changes
Nov 14, 2023
mvicsokolova
force-pushed
the
native-ir-flag-with-integration-tests
branch
from
ad897c1
to
2d36353
Compare
lukellmann
added a commit
to kordlib/kord
that referenced
this pull request
Mar 2, 2024
I added this property in #894 to ensure we'd be using the AtomicFU compiler plugin [1] for native when #855 is merged. However, it seems like a typo slipped through: I think I copied the property from the description of the PR that added this feature to AtomicFU [2]. Turns out there was a typo in that description. The property is kotlinx.atomicfu.enableNativeIrTransformation, not kotlinx.atomicfu.enableNativeIrTransformations as can be seen in the source code [3]. [1] https://github.com/Kotlin/kotlinx-atomicfu/blob/0.23.1/README.md#atomicfu-compiler-plugin [2] Kotlin/kotlinx-atomicfu#363 [3] https://github.com/Kotlin/kotlinx-atomicfu/blob/0.23.1/atomicfu-gradle-plugin/src/main/kotlin/kotlinx/atomicfu/plugin/gradle/AtomicFUGradlePlugin.kt#L38
|
There is a typo in the description of this PR, the property is named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native IR transformations are now available: compiler plugin implements atomic operations via K/N stdlib atomic intrinsics. Atomic arrays, delegated properties and traces are supported by the compiler plugin as well.
To enable Native IR transformations, set the flag
kotlinx.atomicfu.enableNativeIrTransformations=truein thegradle.propertiesfile.See #261