Fixed Stream closed error when generating Kover HTML report
#540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating an HTML report, errors sometimes occur when reading the freemarker template from resources. The exact cause of the error has not yet been determined (relates to the Gradle isolated class loaders), but it disappears when you try to read again. In some cases, it is necessary to increase the number of repetitions, so this setting was made in Kover Gradle plugin. Fixes #510
shanshin
force-pushed
the
report-repeat
branch
from
3c10a2e
to
52da440
Compare
sandwwraith
reviewed
Feb 15, 2024
| @Option(name = "--title", usage = "title in the HTML report", metaVar = "<html-title>") | ||
| private var htmlTitle: String? = null | ||
| @Option(name = "--title", usage = "title in the HTML or XML report", metaVar = "<title>") | ||
| private var title: String? = null |
There was a problem hiding this comment.
Is this change related to the fix in any way?
There was a problem hiding this comment.
Without these changes, a compilation error occurs :)
| @@ -69,6 +70,10 @@ internal abstract class HtmlReportAction : AbstractReportAction<HtmlReportParame | |||
| val files = parameters.files.get() | |||
| val filters = parameters.filters.get() | |||
|
|
|||
| // repeat reading freemarker temple from resources if error occurred, see https://github.com/Kotlin/kotlinx-kover/issues/510 | |||
| // the values are selected empirically so that the maximum report generation time is not much more than a second | |||
| ReportApi.setFreemarkerRetry(7, 150) | |||
There was a problem hiding this comment.
Do you plan to keep the issue open and eventually add a proper fix?
There was a problem hiding this comment.
If, after this fix, the error will still be reproduced, then it will be necessary to understand more deeply
sandwwraith
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating an HTML report, errors sometimes occur when reading the freemarker template from resources. The exact cause of the error has not yet been determined (relates to the Gradle isolated class loaders), but it disappears when you try to read again. In some cases, it is necessary to increase the number of repetitions, so this setting was made in Kover Gradle plugin.
Fixes #510