Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kotlin 2.0.0 #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DRSchlaubi
Copy link

No description provided.

@e5l e5l requested a review from Mr3zee May 27, 2024 07:44
@e5l
Copy link
Member

e5l commented May 27, 2024

Hey @DRSchlaubi, thanks for the PR, we'll check.

@Mr3zee
Copy link
Collaborator

Mr3zee commented May 27, 2024

Hey, @DRSchlaubi ! Thank you for the interest in the library and your effort the make it better! Unfortunately, I will need to postpone the update to 2.0.0 as it requires complete removal of KSP plugin and migration to Kotlin Compiler Plugin. Good news is, I'm already working on it, but it will be delivered with a delay, because compiler plugins require a lot of attention.

@DRSchlaubi
Copy link
Author

Just out of curiosity, why does KSP need to be removed, all the tests passed fine?

@Mr3zee
Copy link
Collaborator

Mr3zee commented May 28, 2024

It's not just for 2.0.0, we are removing KSP from the whole project. There are a couple of reasons: not working gradle configuration caches, no ability to hide generated code, necessity to explicitly add KSP gradle plugin. I didn't measure, but i suspect that KSP is also slower than kotlin compiler plugin

@lppedd
Copy link

lppedd commented May 28, 2024

Happy to see you're moving to a compiler plugin. They seem like what the community will mostly work with in the future, if docs gets taken care of. KSP is nice for delivering fast, but getting rid of an additional build time dependency is always good.

OT, but my only doubt with compiler plugins is about processing order. If more and more plugins start popping up we might end up using many in our build, and I'm not sure if they'd interfere with each other.

@Mr3zee
Copy link
Collaborator

Mr3zee commented May 28, 2024

@lppedd indeed the order of work for compiler plugins is what we are also looking into. Of course, not everything can be taken into account, but we will at least ensure our plugins work smoothly with very popular ones, like kotlinx.serialization

@Mr3zee Mr3zee mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants