You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried using the ReplaceWith for broadcastIn in 1.4.0 and it has several issues.
Firstly it doesn't handle CoroutineStart other than lazily which seems a bit dangerous as it might change behavior.
Secondly the order of the parameters is incorrect. In the ReplaceWith it's listed as shareIn(scope, 0, SharingStarted.Lazily) while the final version of shareIn has scope, started, replay.
One solution would be to add a deprecated, single argument, overload for broadcastIn which is replaced with shareIn(scope) and the 2 argument overload can have its ReplaceWith removed since it cannot be done reliably.
The text was updated successfully, but these errors were encountered:
I tried using the
ReplaceWith
forbroadcastIn
in 1.4.0 and it has several issues.Firstly it doesn't handle
CoroutineStart
other than lazily which seems a bit dangerous as it might change behavior.Secondly the order of the parameters is incorrect. In the
ReplaceWith
it's listed asshareIn(scope, 0, SharingStarted.Lazily)
while the final version ofshareIn
hasscope, started, replay
.Lastly it was just broken:
One solution would be to add a deprecated, single argument, overload for
broadcastIn
which is replaced withshareIn(scope)
and the 2 argument overload can have itsReplaceWith
removed since it cannot be done reliably.The text was updated successfully, but these errors were encountered: