Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withContext shall provide structured CoroutineScope #617

Closed
elizarov opened this issue Sep 26, 2018 · 0 comments
Closed

withContext shall provide structured CoroutineScope #617

elizarov opened this issue Sep 26, 2018 · 0 comments

Comments

@elizarov
Copy link
Contributor

In the following test:

suspend fun foo() = withContext(Dispatchers.Default) { 
    launch { delay(1000 } 
}

withContext invocation shall wait for its children (launch) to complete.
@elizarov elizarov changed the title withContext shall provide structured Scope withContext shall provide structured CoroutineScope Sep 26, 2018
elizarov added a commit that referenced this issue Sep 26, 2018
@elizarov
Fixed CoroutineScope of withContext block for structured concurrency
2573f9d 
* Both are optimized and are rewritten via AbstractCoroutine
* Support for cancelling state is dropped from AbstractContinuation
  and it is now faster, too

Fixes #553
Fixes #617
@elizarov elizarov mentioned this issue Sep 26, 2018
Merged
elizarov added a commit that referenced this issue Sep 26, 2018
@elizarov
Fixed CoroutineScope of withContext block for structured concurrency
5ddeac4 
* Both withContext and coroutineScope are optimized and are rewritten
  as extensions of AbstractCoroutine
* This gives withContext consistent exception handling &
  suppression logic from JobSupport
* Support for cancelling state is dropped from AbstractContinuation
  and it is now faster, too
  (it can be merged with CancellableContinuationImpl in the future)

Fixes #553
Fixes #617
qwwdfsad pushed a commit that referenced this issue Sep 26, 2018
@elizarov @qwwdfsad
Fixed CoroutineScope of withContext block for structured concurrency
e18b015 
* Both withContext and coroutineScope are optimized and are rewritten
  as extensions of AbstractCoroutine
* This gives withContext consistent exception handling &
  suppression logic from JobSupport
* Support for cancelling state is dropped from AbstractContinuation
  and it is now faster, too
  (it can be merged with CancellableContinuationImpl in the future)

Fixes #553
Fixes #617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elizarov