Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lincheck to 2.5 #1520

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Update lincheck to 2.5 #1520

merged 1 commit into from
Dec 26, 2019

Conversation

ndkoval
Copy link
Member

@ndkoval ndkoval commented Sep 6, 2019

Update lincheck to 2.5 and re-write tests with suspend operations using it

@ndkoval ndkoval force-pushed the new-lincheck branch 4 times, most recently from f94049c to 09f29b8 Compare September 11, 2019 23:09
@ndkoval
Copy link
Member Author

ndkoval commented Sep 11, 2019

It also fixes a linearizability bug in ArrayChannel.isClosedForReceive: #1530
UPD: extracted to a separate PR.

@ndkoval ndkoval changed the title Update lincheck to 2.2 (DO NOT MERGE) Update lincheck to 2.2 Sep 11, 2019
@ndkoval ndkoval changed the title Update lincheck to 2.2 Update lincheck to 2.2.1 Sep 11, 2019
@ndkoval ndkoval force-pushed the new-lincheck branch 4 times, most recently from 64801b5 to 66084f5 Compare September 12, 2019 01:20
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that it fails on tests. See https://teamcity.jetbrains.com/viewLog.html?buildId=2530509&buildTypeId=KotlinTools_KotlinxCoroutines_BuildAggregated
on ChannelsLCStressTest.test[ArrayChannel(1)]:

= Invalid execution results: =
Parallel part:
| receiveViaSelect(): suspended | offer(2): true | poll():           null |
|                               | poll():   2    | sendViaSelect(1): void |

@ndkoval ndkoval changed the title Update lincheck to 2.2.1 Update lincheck to 2.3 Sep 27, 2019
@elizarov
Copy link
Contributor

elizarov commented Oct 9, 2019

Still fails on tests.

@ndkoval ndkoval changed the title Update lincheck to 2.3 Update lincheck to 2.4 Oct 18, 2019
@ndkoval ndkoval requested a review from elizarov October 18, 2019 14:35
@ndkoval
Copy link
Member Author

ndkoval commented Oct 18, 2019

I also added a sequential channel implementation

Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stress tests are still too slow. On Mac they take ~1h40m each. That's too much. In develop branch each stress test takes ~4m. Please, tune options to keep stress tests under 5m each.

See https://teamcity.jetbrains.com/viewLog.html?buildId=2630796&buildTypeId=KotlinTools_KotlinxCoroutines_NightlyStressMac&tab=buildLog&branch_KotlinTools_KotlinxCoroutines=new-lincheck#_state=32792

kotlinx.coroutines.linearizability.LockFreeListLCStressTest (1h:40m:15s)
kotlinx.coroutines.linearizability.SegmentQueueLCStressTest (1h:40m:55s)
kotlinx.coroutines.linearizability.MCLockFreeTaskQueueWithRemoveLCStressTest (1h:38m:13s)
kotlinx.coroutines.linearizability.MCLockFreeTaskQueueWithRemoveLCStressTest.testWithRemoveForQuiescentConsistency (1h:38m:13s)
The build kotlinx-coroutines::Nightly Stress (Mac) #1645 {buildId=2630796} has been running for more than 480 minutes. Terminating...

@ndkoval ndkoval force-pushed the new-lincheck branch 2 times, most recently from 1d47511 to 27fc5ba Compare December 11, 2019 23:41
@ndkoval ndkoval changed the title Update lincheck to 2.4 Update lincheck to 2.5 Dec 11, 2019
@ndkoval ndkoval force-pushed the new-lincheck branch 2 times, most recently from 8bd23c4 to 769078b Compare December 16, 2019 22:34
@ndkoval ndkoval force-pushed the new-lincheck branch 4 times, most recently from 564fca6 to fba1900 Compare December 24, 2019 16:03
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Good to go!

@elizarov elizarov merged commit 4f24a7a into develop Dec 26, 2019
@elizarov elizarov deleted the new-lincheck branch December 26, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants