Indicate that root README should be updated with new contributions #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Good addition. |
elizarov
suggested changes
Feb 13, 2020
integration/README.md
Outdated
| @@ -23,5 +23,6 @@ Follow the following simple guidelines when contributing integration with your f | |||
| * List of modules in this document. | |||
| * List of modules in top-level [`settings.gradle`](../settings.gradle). | |||
| * List of modules at the root of documentation site in [`site/docs/index.md`](../site/docs/index.md). | |||
| * List of integrations in the root [README.md](../README.md) | |||
There was a problem hiding this comment.
Nit: should end the sentence with comma.
There was a problem hiding this comment.
@elizarov I've made a change, but used a period rather than a comma, since the surrounding code used the periods as well. If you'd still like a comma, I'm happy to use that instead.
MariusVolkhart
force-pushed
the
mv/integrationDocs
branch
from
2349a30
to
06b30a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.