Remove requirement that job of the pre-created JobCancelNode have to … #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be equal to outer job Job is supposed to be "sealed" interface, but we also have non-sealed Deferred that can be successfully implemented via delegation and such delegation may break code (if assertions are enabled!) in a very subtle ways. This assertion is our internal invariant that we're preserving anyway, so it's worth to lift it to simplify life of our users in the future Fixes #2423
elizarov
approved these changes
Dec 4, 2020
|
My first attempt to fix it did not work out on JS. Now I've taken a different approach which also simplifies some code around JobNode. Please, review. |
elizarov
force-pushed
the
fix-delegation
branch
from
a5e8496
to
dd5c9ca
Compare
qwwdfsad
commented
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…be equal to outer job
Job is supposed to be "sealed" interface, but we also have non-sealed Deferred that can be successfully implemented via delegation and such delegation may break code (if assertions are enabled!) in a very subtle ways.
This assertion is our internal invariant that we're preserving anyway, so it's worth to lift it to simplify life of our users in the future
Fixes #2423