Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NPM validation #3312

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Remove NPM validation #3312

merged 1 commit into from
Jun 7, 2022

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented Jun 6, 2022

We will drop complete support of NPM as soon as JS IR is declared stable and this test is already a deadweight as it was never run due to misconfiguration

We will drop complete support of NPM as soon as JS IR is declared stable and this test is already a deadweight as it was never run due to misconfiguration
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sure, but where was the misconfiguration? On the TeamCity side?

@qwwdfsad
Copy link
Collaborator Author

qwwdfsad commented Jun 7, 2022

Yes, dryRun was never applied

@qwwdfsad qwwdfsad merged commit cc5b86a into develop Jun 7, 2022
@qwwdfsad qwwdfsad deleted the remove-npm-validation branch June 7, 2022 12:32
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
We will drop complete support of NPM as soon as JS IR is declared stable and this test is already a deadweight as it was never run due to misconfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants