Properly round Duration instances to milliseconds
#3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincianfarini
commented
Oct 23, 2023
kevincianfarini
commented
Oct 23, 2023
| @@ -133,7 +133,7 @@ public suspend fun delay(timeMillis: Long) { | |||
| } | |||
|
|
|||
| /** | |||
| * Delays coroutine for a given [duration] without blocking a thread and resumes it after the specified time. | |||
| * Delays coroutine for at least the given [duration] without blocking a thread and resumes it after the specified time. | |||
There was a problem hiding this comment.
I felt that this was an important distinction which felt natural to make here. Please let me know if I should revert.
JakeWharton
reviewed
Oct 23, 2023
dkhalanskyjb
suggested changes
Oct 23, 2023
kevincianfarini
requested review from
dkhalanskyjb,
JakeWharton and
denis-bezrukov
dkhalanskyjb
suggested changes
Oct 24, 2023
kevincianfarini
commented
Oct 24, 2023
|
Hi! If there's any other desired changes I'm happy to make them. |
|
Please rebase your changes on top of |
Prior to this commit Durations used in for delays or timeouts lost their nanosecond granularity when being converted to a millisecond Long value. This effectively meant that delays could resume prior to when they were scheduled to do so. This commit solves this by rounding a Duration with nanosecond components up to the next largest millisecond. Closes Kotlin#3920
kevincianfarini
force-pushed
the
kcianfarini/delay-properly
branch
from
4071820
to
5e6ab6f
Compare
|
Done. Sorry, I should have checked the contribution guide first. |
|
Do we think there's a chance this will be merged prior to the next version release? 😄 |
|
Yes. |
|
Nice! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit Durations used for delays or timeouts lost their nanosecond granularity when being converted to a millisecond Long value. This effectively meant that delays could resume prior to when they were scheduled to do so.
This commit solves this by rounding a Duration with nanosecond components up to the next largest millisecond.
Closes #3920