Limited parallelism improvements #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ import kotlin.jvm.* | |||
| * associated native resources (threads or native workers). It should not be allocated in place, | |||
| * should be closed at the end of its lifecycle, and has non-trivial memory and CPU footprint. | |||
| * If you do not need a separate thread pool, but only have to limit effective parallelism of the dispatcher, | |||
| * it is recommended to use [CoroutineDispatcher.limitedParallelism] instead. | |||
| * it is recommended to use `Dispatchers.IO.limitedParallelism(1)` or `Dispatchers.Default.limitedParallelism(1)` instead. | |||
There was a problem hiding this comment.
An interactive link to limitedParallelism could help, I think.
There was a problem hiding this comment.
Added, please check
Co-authored-by: Dmitry Khalanskiy <52952525+dkhalanskyjb@users.noreply.github.com>
dkhalanskyjb
approved these changes
Apr 26, 2024
Corje
pushed a commit
that referenced
this pull request
May 10, 2024
* Provide toString implementation for limitedParallelism * Improve documentation of limitedParallelism Co-authored-by: Dmitry Khalanskiy <52952525+dkhalanskyjb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I figure out stabilization details, these are pretty straightforward changes that can be merged into minor releases