Fix a regression in JobSupport memory consumption #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup to 65ef6ea: that commit made `JobSupport` consume more memory by making the information about whether a callback should be invoked when the job enters the cancelling state be represented as a boolean flag and not part of the object class hierarchy. Now that flag is a virtual function instead.
dkhalanskyjb
changed the title
Corje
pushed a commit
that referenced
this pull request
May 10, 2024
Fixup to 65ef6ea: that commit made `JobSupport` consume more memory by making the information about whether a callback should be invoked when the job enters the cancelling state be represented as a boolean flag and not part of the object class hierarchy. Now that flag is a virtual function instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup to 65ef6ea: that commit made
JobSupportconsume more memory by making the information about whether a callback should be invoked when the job enters the cancelling state be represented as a boolean flag and not part of the object class hierarchy.Now that flag is a virtual function instead.