Add the crossorigin attribute to the <script> element
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is helpful to check the integrity for libraries like htmx.
lorenzsimon
changed the title
crossorigin attribute to the script element
lorenzsimon
changed the title
crossorigin attribute to the script elementcrossorigin attribute to the <script> element
e5l
approved these changes
Jan 8, 2024
|
Hey @lorenzsimon, thanks for the PR. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is very interesting in combination with other tools like htmx. To safely include such libraries we should allow the crossorigin in the script tag as described here
See here for more details about the attribute.