Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasmJs target support. #251

Merged
merged 2 commits into from Jan 12, 2024
Merged

Add wasmJs target support. #251

merged 2 commits into from Jan 12, 2024

Conversation

IlyaGulya
Copy link
Contributor

@IlyaGulya IlyaGulya commented Jan 11, 2024 •
edited

Changes:

  1. Added wasmJs target support
  2. WasmJS target builds upon Element instead of HTMLElement because SVGElement does not inherit HTMLElement and class cast exception happens.
  3. Rewritten generators using KotlinPoet:
  • common: gen-consumer-tags.kt
  • js: gen-consumer-tags-js.kt
  • js: gen-event-attrs-js.kt
  • wasmJs: gen-consumer-tags-js.kt
  • wasmJs: gen-event-attrs-js.kt
    Now gen-consumer-tags.kt and gen-consumer-tags-js.kt are generated using single generator.
  1. Added tests for js and wasmJs which are checking that every generated tag is correctly instantiated in runtime.
  2. Upgraded kotlin to 1.9.22
  3. Upgraded gradle to 8.5

@e5l e5l self-requested a review January 11, 2024 11:02
@e5l
Copy link
Member

e5l commented Jan 11, 2024

Hey @IlyaGulya, thanks for the PR. Could you rebase it on the latest master? the generated files has some conflicts

@IlyaGulya
Copy link
Contributor Author

Sure

@IlyaGulya
Add wasmJs target support. Rewrite several code generators to use Kot…
7d5a1a6 
…linPoet. Add tests checking that every generated tag is instantiated without issues.
@IlyaGulya
Copy link
Contributor Author

@e5l done!

@e5l e5l self-assigned this Jan 12, 2024
e5l
e5l approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! LGTM

@e5l e5l merged commit c947795 into Kotlin:master Jan 12, 2024
1 check passed
@IlyaGulya
Copy link
Contributor Author

Wow, that was fast 🙂

@IlyaGulya IlyaGulya deleted the feature/wasmJs branch January 17, 2024 04:54
@IlyaGulya IlyaGulya mentioned this pull request Jan 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees

@e5l e5l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IlyaGulya @e5l